[PATCH] D97109: [clangd] Add support for auxiliary triple specification

sammccall added a comment. No apology necessary! I think it's worth working out where best to put the fix, but the fix itself is the hard part from my perspective (not knowing much about cuda and other dialects). So this is much appreciated. Please let me know if you hit any problems with the

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT abandoned this revision. oToToT added a comment. Thanks sammccall for reviewing this and for the great idea of the whole plan. I will work on the plan (maybe without the third one) to fix the problem described here. Sorry for a poor submission here again. Repository: rG LLVM Github M

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

sammccall added a comment. Thanks for working this out! Clearly there are some layering concerns here - clangd is "just" a clang tool that parses some code, and this is some pretty hairy clang internal logic we're copying here. Practical concerns: - it it could very easily skew from clang (e.g

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT added inline comments. Comment at: clang/lib/Frontend/PrecompiledPreamble.cpp:311 llvm::ErrorOr PrecompiledPreamble::Build( const CompilerInvocation &Invocation, Though this file is in clang, clangd use this function to prepare preamble in `Preamb

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT updated this revision to Diff 325186. oToToT added a comment. re-upload diff with full context, sorry for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97109/new/ https://reviews.llvm.org/D97109 Files: clang-tools-extra/clangd/Compi

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

njames93 added a comment. Please upload diffs with full context. This can be done by passing `-U99` to diff or by using arcanist to upload your patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D97109: [clangd] Add support for auxiliary triple specification

oToToT created this revision. oToToT added reviewers: jdoerfert, sammccall, ilya-biryukov. oToToT added a project: clang-tools-extra. Herald added subscribers: usaxena95, kadircet, arphaman. oToToT requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald a