[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-03-17 Thread Zakk Chen via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG95c0125f2bc6: [Clang][RISCV] Add rvv vsetvl and vsetvlmax intrinsic functions. (authored by khchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-03-17 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 _

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-03-17 Thread Zakk Chen via Phabricator via cfe-commits
khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:169 +Builder.defineMacro("__rvv_e64", "3"); +Builder.defineMacro("__rvv_e128", "4"); + craig.topper wrote: > Are intending to support e128

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-03-17 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 331267. khchen marked 2 inline comments as done. khchen added a comment. 1. address Craig's comments. 2. update test by using 2>&1 instead of 2>%t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https:/

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-03-15 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +// SEW +Builder.defineMacro("__rvv_e8", "0"); I'm not sure if it makes sense to expose these from the compiler. Should we define them in the header instead? They don

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-02-25 Thread Zakk Chen via Phabricator via cfe-commits
khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1052 uint8_t PrevExt = (*Defs.begin())->getRISCV_Extensions(); - bool NeedEndif = emitExtDefStr(PrevExt, OS); + bool NeedEndif = + (*Defs.begin())->hasAutoDef() ? emitExtDefStr(PrevExt, OS)

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-02-25 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 326612. khchen marked 3 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 Files: clang/include

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-02-25 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:165 + // and it will have to be provided manually. See IntrinsicTypes below. + bit HasManualCodegen = true; + Why do we need a flag? Can we just make ManualCodegen and Man

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-02-25 Thread Zakk Chen via Phabricator via cfe-commits
khchen updated this revision to Diff 326310. khchen added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96843/new/ https://reviews.llvm.org/D96843 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Basic/Targets/RISC

[PATCH] D96843: [Clang][RISCV] Add vsetvl and vsetvlmax.

2021-02-16 Thread Zakk Chen via Phabricator via cfe-commits
khchen created this revision. khchen added reviewers: craig.topper, jrtc27, rogfer01, frasercrmck, HsiangKai, evandro. Herald added subscribers: vkmr, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zz