Conanap added a comment.
Hello,
One of our PowerPC buildbots is failing because it is named `lld-multistage`,
which matches with this CHECK-NOT in
`clang/test/Driver/hip-sanitize-options.hip`: `;CHECK-NOT: {{"[^"]*lld[^"]*".*
".*hip.bc"}}`.
I've created a patch and if you could review it that'
This revision was automatically updated to reflect the committed changes.
yaxunl marked 3 inline comments as done.
Closed by commit rG51ade31e6789: [HIP] Support device sanitizer (authored by
yaxunl).
Herald added a project: clang.
Changed prior to commit:
https://reviews.llvm.org/D96835?vs=324
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/Driver/ToolChain.cpp:1185
+ToolChain::getHIPDeviceLibs(const ArgList &DriverArgs) const {
+ return llvm::SmallVector();
+}
tra wrote:
> Nit: It could be just `return {}`
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Nice. LGTM with few minor nits.
Comment at: clang/lib/Driver/ToolChain.cpp:1185
+ToolChain::getHIPDeviceLibs(const ArgList &DriverArgs) const {
+ return llvm::SmallVector();
+}
--
yaxunl updated this revision to Diff 324510.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
revised by Artem's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96835/new/
https://reviews.llvm.org/D96835
Files:
clang/include/clang/Driver/Options.td
clang/incl
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/include/clang/Driver/Options.td:939
"__cyg_profile_func_enter and __cyg_profile_func_exit">;
+def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">,
+ HelpText<"Enable sanitizer for AMDGPU tar
tra added inline comments.
Comment at: clang/include/clang/Driver/Options.td:939
"__cyg_profile_func_enter and __cyg_profile_func_exit">;
+def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">,
+ HelpText<"Enable sanitizer for AMDGPU target.">;
We do have `BoolFOp
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: jansvoboda11, dang, kerbowa, tpr, nhaehnle, jvesely.
yaxunl requested review of this revision.
Add option -fgpu-sanitize to enable sanitizer for AMDGPU target.
Since it is experimental, it is off by default.
h
