[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

rjmccall added a comment. In D96802#2569810 , @varungandhi-apple wrote: >> The TargetInfo classes are already target-architecture-specific, so it's >> somewhat strange for them all to funnel to a single function that then >> immediately switches on the

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple abandoned this revision. varungandhi-apple added a comment. I've updated the earlier patch https://reviews.llvm.org/D95561 to include this change, so that we don't have an in-between state where we erroneously claim that we support a bunch of targets which we don't actually sup

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple added a comment. > The TargetInfo classes are already target-architecture-specific, so it's > somewhat strange for them all to funnel to a single function that then > immediately switches on the target architecture. IMO ideally, the whole thing would be stored as a table of Ta

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

rjmccall added a comment. The TargetInfo classes are already target-architecture-specific, so it's somewhat strange for them all to funnel to a single function that then immediately switches on the target architecture. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

aschwaighofer accepted this revision. aschwaighofer added a comment. This revision is now accepted and ready to land. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96802/new/ https://reviews.llvm.org/D96802 ___

[PATCH] D96802: [Clang] Add proper target checks for SwiftAsync convention.

varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. Herald added subscribers: dexonsmith, pengfei, kbarton, kristof.beyls, jgravelle-google, sbc100, nemanjai, dschuff. varungandhi-apple requested review of this revision. Herald added subscribers: cfe-commits, ahe