[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b83837af6f4: [clangd] Bind outgoing calls through LSPBinder too. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ http

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet accepted this revision. kadircet added a comment. still LG! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324110. sammccall added a comment. fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/c

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod &Handler) { kadircet wrote: > sa

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! can't wait for the unique_function sfinae fix :) Comment at: clang-tools-extra/clangd/LSPBinder.h:185 + +LSPBinder::UntypedOutgoingNotification inline LSPBinder::

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324025. sammccall added a comment. OK, the awful proxy object thing works :-) It requires a SFINAE fix to unique_function though, which i'll send separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 324012. sammccall marked an inline comment as done. sammccall added a comment. rebase & address comments (except bind out API, still to come) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://r

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod &Handler) { kadircet wrote: > we

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

kadircet added a comment. mostly LG. some comments around the way we set up outgoinmethod stubs though. Comment at: clang-tools-extra/clangd/LSPBinder.h:88 + template + void outgoingMethod(llvm::StringLiteral Method, + OutgoingMethod &Handler) {

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall updated this revision to Diff 323810. sammccall added a comment. Remove fixedme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96717/new/ https://reviews.llvm.org/D96717 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-

[PATCH] D96717: [clangd] Bind outgoing calls through LSPBinder too. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The redundancy around work-done-progress