[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2141e3a08c: [clangd] Improve document symbols support for Objective-C categories and methods (authored by dgoldman). Repository: rG LLVM Github

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 327146. dgoldman added a comment. Add comment and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-too

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:176 +std::string getSymbolName(ASTContext &Ctx, const NamedDecl &ND) { + if (const auto *Container

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 326719. dgoldman marked an inline comment as done. dgoldman added a comment. Limit changes to document symbols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files:

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:228 +Out << (Method->isInstanceMethod() ? '-' : '+'); +Method->getSelector().print(Out); +return Out.str(); sammccall wrote: > in t

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast(&ND)) +return printObjCContainer(*C); sammccall wrote: > I'm not sure this fits with the contract of

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

sammccall added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast(&ND)) +return printObjCContainer(*C); I'm not sure this fits with the contract of printName, which really is to print the name of the symbol r

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 323443. dgoldman added a comment. - Add class method test case + swap to auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

njames93 added a comment. I'm not an objc guy, but can you add a test case demonstrating class(?) methods showing as `+name:`? Comment at: clang-tools-extra/clangd/AST.cpp:224-226 + if (const ObjCContainerDecl *C = dyn_cast(&ND)) +return printObjCContainer(*C); + if (con

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Categories will now be printed