This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c5f17e701ff: [clangd] Delay binding LSP methods until
initialize. NFC (authored by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
sammccall updated this revision to Diff 323793.
sammccall marked an inline comment as done.
sammccall added a comment.
address comments & rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96608/new/
https://reviews.llvm.org/D96608
Files:
clan
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:165
return false;
-if (!Server.Server) {
- elog("Notification {0} before initialization", Method);
-} else if (Method == "$/ca
kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:165
return false;
-if (!Server.Server) {
- elog("Notification {0} before initialization", Met
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This is NFC because the MessageHandler re
