This revision was automatically updated to reflect the committed changes.
Closed by commit rGaa842896299b: [DebugInfo] Keep the DWARF64 flag in the
module metadata (authored by ikudrin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96597/new/
https
dblaikie added inline comments.
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:396
+ bool Dwarf64 =
+ (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64()) &&
+ DwarfVersion >= 3 && // DWARF64 was introduced in DWARFv3.
ikudrin
ikudrin added a comment.
Thank you, @dblaikie!
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:396
+ bool Dwarf64 =
+ (Asm->TM.Options.MCOptions.Dwarf64 || MMI->getModule()->isDwarf64()) &&
+ DwarfVersion >= 3 && // DWARF64 was introduced in DWARFv3.
---
dblaikie accepted this revision.
dblaikie added a subscriber: aprantl.
dblaikie added a comment.
This revision is now accepted and ready to land.
@aprantl - mind having a look at this/signing off as well, if you're OK with
it? Since it's a core metadata change, wouldn't mind some extra eyes on it
ikudrin created this revision.
ikudrin added reviewers: ayermolo, MaskRay, wenlei, dblaikie.
ikudrin added projects: LLVM, clang, debug-info.
Herald added subscribers: dexonsmith, ormris, hiraditya.
ikudrin requested review of this revision.
This allows the option to affect the LTO output. `Module
