[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-16 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96d229c9abdf: [flang][driver] Add options for unparsing (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-15 Thread Faris Rehman via Phabricator via cfe-commits
FarisRehman accepted this revision. FarisRehman added a comment. This revision is now accepted and ready to land. Thanks for clarifying Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 __

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-15 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added a comment. In D96483#2563323 , @FarisRehman wrote: > Do you know what the use of `GetActionKindName` in `FrontendOptions.h` is, as > it is currently not being called anywhere and whilst this patch currently > does not update that method

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-15 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 323756. awarzynski added a comment. Updated lit.cfg.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 Files: clang/include/clang/Driver/Options.td flang/include

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-15 Thread Faris Rehman via Phabricator via cfe-commits
FarisRehman added a comment. Thanks for working on this @awarzynski Could you please clarify the situation regarding `GetActionKindName` in `FrontendOptions.h` as it is currently not being used anywhere and this patch currently does not update that method with the 2 new cases. Other than that, l

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-11 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; tskeith wrot

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-11 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 323054. awarzynski added a comment. Fix typo in f18.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 Files: clang/include/clang/Driver/Options.td flang/includ

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-11 Thread Tim Keith via Phabricator via cfe-commits
tskeith added inline comments. Comment at: flang/tools/f18/f18.cpp:541 driver.debugNoSemantics = true; -} else if (arg == "-funparse") { +} else if (arg == "-funparse" || arg == "-fdebug_unparse") { driver.dumpUnparse = true; This should be

[PATCH] D96483: [flang][driver] Add options for unparsing

2021-02-11 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski created this revision. Herald added subscribers: dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: jansvoboda11. awarzynski requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the following co