vitalybuka updated this revision to Diff 323202.
vitalybuka marked 5 inline comments as done.
vitalybuka added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
Files:
clang/lib/CodeGen/Ba
tejohnson added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1066
PassBuilder::OptimizationLevel Level)
{
+if (CodeGenOpts.OptimizationLevel == 0) {
+ if (!CodeGenOpts.ThinLTOIndexFile.empty())
vitalybuka updated this revision to Diff 322935.
vitalybuka added a comment.
new line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGen/thinlto-
vitalybuka added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549
+ Conf.OptPassBuilderHook = [&](PassBuilder &PB) {
+addSanitizers(TargetTriple, CGOpts, LOpts, PB);
+ };
tejohnson wrote:
> I can't find where this is defined.
to avoid noi
vitalybuka updated this revision to Diff 322934.
vitalybuka added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
Files:
clang/lib/CodeGen/BackendUtil.cpp
clang/test/CodeGen/thinlto-di
vitalybuka updated this revision to Diff 322924.
vitalybuka marked an inline comment as done.
vitalybuka added a comment.
update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
Files:
clang/lib/CodeGen/Ba
aeubanks added a comment.
This makes sense to me, we need to add the PassBuilder callbacks in both the
prelink/normal and postlink steps, and those are separated.
Comment at: llvm/include/llvm/LTO/Config.h:54
+ /// For adding passes that run by opt.
+ std::function OptPassBu
tejohnson added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:1549
+ Conf.OptPassBuilderHook = [&](PassBuilder &PB) {
+addSanitizers(TargetTriple, CGOpts, LOpts, PB);
+ };
I can't find where this is defined.
Comment at: l
vitalybuka added a comment.
Test will follow if you agree with approach.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96456/new/
https://reviews.llvm.org/D96456
___
cfe-commits mailing list
cfe-commits@