[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10826ea7b1c1: [flang][driver] Add extension options and -finput-charset (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.o

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323938. FarisRehman added a comment. Rebase off main Rebase off main and remove dependency on patch D96344 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96407/new/ https

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. Thank you for addressing my comments. LGTM! Please add missing `newline` chars before merging ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/implicit-none.f90:10 +! RUN: not %flang-new -fsyntax-only -fimplicit-none %s 2>&1 | FileCheck %s --check-prefix=ALWAYS +! RUN: %flang-new -fsyntax-only -fno-implicit-none %s 2>&1 | FileCheck %s --allow-emp

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323717. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Address review comment This revision addresses a review comment by @awarzynski Summary of changes: - Rebase off the latest D96344 revisi

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

awarzynski added a comment. Thank you for submitting this @FarisRehman ! Overall this looks good to me. I've left a few minor comments inline. Also, I think that it is worth adding a help message for `-finput-charset`. Lack of it in `clang` feels like an accidental omission. We can follow GCC h

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commit