[PATCH] D96244: [clangd] Introduce Modules

sammccall added a comment. In D96244#2566225 , @dblaikie wrote: > "modules" is a pretty overloaded term in Clang (between llvm Modules and > Clang Modules and now C++ standard Modules) - any chance of some other term > that might be less overloaded in th

[PATCH] D96244: [clangd] Introduce Modules

dblaikie added a comment. "modules" is a pretty overloaded term in Clang (between llvm Modules and Clang Modules and now C++ standard Modules) - any chance of some other term that might be less overloaded in this space? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

Re: [PATCH] D96244: [clangd] Introduce Modules

oops, d25fbaa4a4a1284e998f545d45280e976c29cc85 should fix the issue. On Sat, Feb 13, 2021 at 2:54 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > In D96244#2558345 , @sammccall > wrote: > > > I'm a little

[PATCH] D96244: [clangd] Introduce Modules

RKSimon added a comment. In D96244#2558345 , @sammccall wrote: > I'm a little bit nervous about adding this with *no* usage, but it keeps the > patch size down :-) Indeed - this has broken at least one buildbot (http://lab.llvm.org:8011/#/builders/57) d

[PATCH] D96244: [clangd] Introduce Modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2423a3863e07: [clangd] Introduce Modules (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D96244: [clangd] Introduce Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:33 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/FunctionExtras.h" sammccall wrote: > (include no longer used?) well it is still

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 323361. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-ex

[PATCH] D96244: [clangd] Introduce Modules

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.h:33 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/FunctionExtr

[PATCH] D96244: [clangd] Introduce Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Module.h:25 +/// - module hooks can be called afterwards. +/// - modules can be destroyed before/after ClangdServer and ClangdLSPServer +///FIXME: Once we make server facilities available to modules, we'll

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 323290. kadircet marked 7 inline comments as done. kadircet added a comment. - Define destruction order - Get rid of Module.cpp and Module::id - Define begin/end iterators for ModuleSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D96244: [clangd] Introduce Modules

sammccall added a comment. I'm a little bit nervous about adding this with *no* usage, but it keeps the patch size down :-) Comment at: clang-tools-extra/clangd/Module.cpp:1 +//===--- Module.cpp - Main clangd server code *- C++-*-===// +//

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 322754. kadircet added a comment. - Changes to propagate moduleset into clangd(lsp)server Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-extra/cl