This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6329ce75da7a: [clangd] Expose absoluteParent helper
(authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D96123?vs=324947&id=
kadircet updated this revision to Diff 324947.
kadircet added a comment.
- Get rid of parent_path usage for real
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96123/new/
https://reviews.llvm.org/D96123
Files:
clang-tools-extra/clangd/ConfigProvi
kadircet updated this revision to Diff 324946.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Update comment.
- Get rid of a parent_path usage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96123/new/
https://reviews.llvm.or
sammccall accepted this revision.
sammccall added a comment.
Thanks!
Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:101
// Compute absolute paths to all ancestors (substrings of P.Path).
llvm::StringRef Parent = path::parent_path(P.Path);
llvm::Sma
kadircet updated this revision to Diff 323820.
kadircet added a comment.
- Expose absoluteParent instead of whole traverse action
- Use helper in existing places that use path::parent_path for traversal
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
kadircet marked an inline comment as done.
kadircet added a comment.
> maybe we should expose absoluteParent instead?
doing that instead. also updating tidyprovider and configyamlparser to make use
of this helper now, PTAL.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/support/Path.h:33
+// deepest directory and going up to root. Stops whenever action succeeds.
+void actOnAllParentDirectories(P
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
Will be used in other components that need
