[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d5f00093be: [ASTMatchers] Fix hasParent while ignoring unwritten nodes (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D96113#2569441 , @steveire wrote: > Update Thanks for the extra context, that's useful -- LGTM! Comment at: clang/

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire added inline comments. Comment at: clang/lib/AST/ParentMapContext.cpp:174 +{ + auto AncestorNodes = matchParents( + ParentList, this); aaron.ballman wrote: > Not needing to be solved in this patch, but do we eventually need

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire updated this revision to Diff 324396. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/ https://reviews.llvm.org/D96113 Files: clang/include/clang/AST/ParentMapContext.h clang/lib/AST/ParentMapC

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

aaron.ballman added a comment. Can you add a bit more description to the review summary about what's being fixed? It helps the reviewers with context but it also helps when doing code archeology on changes. Comment at: clang/lib/AST/ParentMapContext.cpp:138 + // diff

[PATCH] D96113: [ASTMatchers] Fix hasParent while ignoring unwritten nodes

steveire updated this revision to Diff 321990. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96113/new/ https://reviews.llvm.org/D96113 Files: clang/include/clang/AST/ParentMapContext.h clang/lib/AST/ParentMapC