[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-03-09 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. @NoQ wrote: > IIUC this is roughly the first time ever when `SValBuilder` starts emitting > symbols of float type. This is a huge change with an almost unlimited scope > of unexpected side effects and very rigorous testing is required to > understand the actual e

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-03-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > tiny patch IIUC this is roughly the first time ever when `SValBuilder` starts emitting symbols of float type. This is a huge change with an almost unlimited scope of unexpected side effects and very rigorous testing is required to understand the actual effect of this pat

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-02-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. This is just a note for me to correctly rebase it in the future: https://reviews.llvm.org/D96090?vs=321602&id=322422#toc CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 _

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-02-05 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. void clang_analyzer_dumpi(int); void clang_analyzer_dumpf(float); void clang_analyzer_dumpip(int*); void clang_analyzer_dumpfp(float*); void SymbolCast_of_float_type_aux(int *p) { *p += 1; clang_analyzer_dumpi(*p); // (Previously): Unknown -> (Now):

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-02-04 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 321585. ASDenysPetrov added a comment. Updated. Moved comments as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp clang/lib/StaticAnalyzer

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-02-04 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. Hi, folk! Please, review this tiny patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 _

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

2021-02-01 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, xazax.hun, baloghadamsoftware, steakhal, vsavchenko. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet. ASDenysPetr