This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbff6d9bb0f6d: [clang][cli] Report result of ParseLangArgs
(authored by jansvoboda11).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95792/new/
https://reviews.llvm.org/D95792
jansvoboda11 added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3096
+
+ return Success;
}
dexonsmith wrote:
> Would this avoid the changes above?
> ```
> return Success && !Diags.hasErrorOccurred();
> ```
> ?
>
> Alternatively, might
jansvoboda11 updated this revision to Diff 321136.
jansvoboda11 added a comment.
Rely on DiagnosticsEngine when reporting parsing result
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95792/new/
https://reviews.llvm.org/D95792
Files:
clang/includ
dexonsmith added inline comments.
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3096
+
+ return Success;
}
Would this avoid the changes above?
```
return Success && !Diags.hasErrorOccurred();
```
?
Alternatively, might it be cleaner to shove the `Succe
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch correctly reports success/failure of `ParseLangArgs`. Besides being
consistent
