[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8530fc3039: [clang] implicitly delete space ship operator with function pointers (authored by mizvekov, committed by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 326514. mizvekov added a comment. Updated comment and moved tests to correct places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409 Files: clang/lib/Sema/SemaDeclCX

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

rsmith added a comment. Thanks, this looks fine. I wish we had a better way to determine whether a builtin comparison is usable without actually building a use of it. :-( In D95409#2565227 , @mizvekov wrote: > By the way I realize I may not have put the

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov added a comment. Ping. By the way I realize I may not have put the new tests in the appropriate place. Any guidance there welcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95409/new/ https://reviews.llvm.org/D95409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov updated this revision to Diff 319400. mizvekov added a comment. added tests adds test that will catch original bug also adds some tests on default equality/relational operators this last one would have caught the issue of not accepting equality operator for function pointers, had I not

[PATCH] D95409: [clang] implicitly delete space ship operator with function pointers

mizvekov created this revision. Herald added a subscriber: yaxunl. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See bug #48856 Definitions of classes with member function pointers and default spaceship operator were getting acc