This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd5f5deee9ee9: Reland "[DebugInfo][CodeView] Use
as the display name for lambdas" (authored by akhuang).
Repository:
rG LLVM Github Mono
akhuang updated this revision to Diff 320020.
akhuang added a comment.
Fix test / string code after test failures
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://reviews.llvm.org/D95187
Files:
clang/include/clang/AST/Mangle.h
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGd73564c51003: [DebugInfo][CodeView] Use as
the display name for lambdas. (authored by akhuang).
Changed prior to commit:
https://review
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://reviews.llvm.org/D95187
__
akhuang updated this revision to Diff 319668.
akhuang added a comment.
make function return lambda string, and add test for lambda in function
parameters
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://reviews.llvm.org/D95187
Fil
akhuang added inline comments.
Comment at: clang/include/clang/AST/Mangle.h:92
+ virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0;
+
rnk wrote:
> akhuang wrote:
> > rnk wrote:
> > > I think I would prefer to have this return a number. I think
rnk added inline comments.
Comment at: clang/include/clang/AST/Mangle.h:92
+ virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0;
+
akhuang wrote:
> rnk wrote:
> > I think I would prefer to have this return a number. I think CGDebugInfo
> > sho
akhuang updated this revision to Diff 319379.
akhuang added a comment.
Avoid using getLambdaId function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://reviews.llvm.org/D95187
Files:
clang/include/clang/AST/Mangle.h
clang/lib/
akhuang added inline comments.
Comment at: clang/include/clang/AST/Mangle.h:92
+ virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0;
+
rnk wrote:
> I think I would prefer to have this return a number. I think CGDebugInfo
> should be responsibl
rnk added a comment.
I see a potential issue, but I think this looks good otherwise.
Comment at: clang/lib/AST/ItaniumMangle.cpp:210
+if (Number == 0)
+ return getAnonymousStructId(Lambda);
+return Number;
This has the potential to create a situati
akhuang updated this revision to Diff 319348.
akhuang marked an inline comment as done.
akhuang added a comment.
change to function returning a number, fill in ItaniumMangle function
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://
akhuang updated this revision to Diff 318657.
akhuang added a comment.
-add to comment
-Add externally visible lambda to test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95187/new/
https://reviews.llvm.org/D95187
Files:
clang/include/clan
rnk added a comment.
I see a variety of presubmit failures in Harbormaster that seem related, so
make sure to check those.
Comment at: clang/include/clang/AST/Mangle.h:92
+ virtual StringRef getLambdaString(const CXXRecordDecl *Lambda) = 0;
+
I think I woul
akhuang created this revision.
akhuang added reviewers: rnk, dblaikie.
akhuang requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Currently (for codeview) lambdas have a string like `` in
their mangled name, and don't have any display name. Th
14 matches
Mail list logo
