This revision was automatically updated to reflect the committed changes.
Closed by commit rG14947cd04701: [clang] Fix signedness in vector bitcast
evaluation (authored by svenvh).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95135/new/
https://rev
svenvh added inline comments.
Comment at: clang/test/CodeGenOpenCL/vector_literals.cl:71
+ // CHECK: extractelement <2 x i32> %{{[0-9]+}}, i64 0
+ unsigned int withCast = ((int2)((int2)(12, 34))).s0;
+}
Anastasia wrote:
> I wonder if both `(int2)` are needed i.
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM, great! Thanks! Perhaps the test can be simplified before committing...
Comment at: clang/test/CodeGenOpenCL/vector_literals.cl:71
+ // CHECK: extractelement <2 x
svenvh created this revision.
svenvh added a reviewer: Anastasia.
svenvh requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The included test case triggered a sign assertion on the result in
`Success()`. This was caused by the APSInt created
