This revision was automatically updated to reflect the committed changes.
Closed by commit rG488a19d00cba: [clang-scan-deps] Support double-dashes in
clang command lines (authored by saudi, committed by aganea).
Changed prior to commit:
https://reviews.llvm.org/D95099?vs=318304&id=338329#toc
R
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95099/new/
https://reviews.llvm.org/D95099
___
cfe-commits mailing list
cfe-co
saudi added a comment.
Ping!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95099/new/
https://reviews.llvm.org/D95099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
saudi added inline comments.
Comment at: clang/test/ClangScanDeps/Inputs/regular_cdb.json:12-16
{
"directory": "DIR",
- "command": "clang -E DIR/regular_cdb_input.cpp -IInputs -o adena.o",
+ "command": "clang -E -IInputs -o adena.o -- DIR/regular_cdb_input.cpp",
"file":
saudi updated this revision to Diff 318304.
saudi marked 5 inline comments as done.
saudi added a comment.
Updated for suggested modifications
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95099/new/
https://reviews.llvm.org/D95099
Files:
clang/lib/Tooling/Tooling.cpp
clang/test/Cl
dexonsmith added a comment.
Thanks for splitting this out! The looks good, just a few nits in line below. I
also have a question about the test.
Comment at: clang/lib/Tooling/Tooling.cpp:440
+ // names.
+ auto ArgsEnd = Args.end();
+ for (auto I = Args.begin(), E = Args.end
saudi updated this revision to Diff 318214.
saudi added a comment.
Bugfixes on the use of the iterator.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95099/new/
https://reviews.llvm.org/D95099
Files:
clang/lib/Tooling/Tooling.cpp
clang/test/ClangScanDeps/Inputs/regular_cdb.json
c
saudi created this revision.
saudi added reviewers: arphaman, jkolek, Bigcheese, kousikk, dexonsmith, hans.
saudi added a project: clang.
Herald added a subscriber: tschuett.
saudi requested review of this revision.
Herald added a subscriber: cfe-commits.
This fixes argument injection when clang c
