This revision was automatically updated to reflect the committed changes.
Closed by commit rGe377c8eeb4aa: Implement dynamic mapAnyOf in terms of
ASTNodeKinds (authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94879/new/
https
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948
+ return {};
+auto VM = Arg.Value.getMatcher();
+if (VM.hasTypedMatch
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948
+ return {};
+auto VM = Arg.Value.getMatcher();
+if (VM.hasTypedMatcher(NK)) {
aaron.ballman wrote:
> Note, this is an example of why use of `auto
steveire updated this revision to Diff 317705.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94879/new/
https://reviews.llvm.org/D94879
Files:
clang/lib/ASTMatchers/Dynamic/Marshallers.h
Index: clang/lib/ASTMat
aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948
+ return {};
+auto VM = Arg.Value.getMatcher();
+if (VM.hasTypedMatcher(NK)) {
Note, this is an example of why use of `auto` is discouraged i
steveire created this revision.
steveire added a reviewer: aaron.ballman.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This reduces template bloat, but more importantly, makes it possible to
construct one from clang-query withou
