This revision was automatically updated to reflect the committed changes.
Closed by commit rG3680cb99a770: [clangd] ignore parallelism level for quick
tasks (authored by qchateau, committed by sammccall).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
qchateau added a comment.
I applied your suggestion as I agree with both. I chose to use
`Opts.AsyncThreadsCount` instead of a hard-coded constant. This way the
"formatting speed" will grow as the user allow more parallelism, which IMO
makes sense.
I agree the implementation had drawbacks but
qchateau updated this revision to Diff 319083.
qchateau added a comment.
- [clangd] fix nits
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94875/new/
https://reviews.llvm.org/D94875
Files:
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
> Save a file, trigger format-on-save, which hangs because clangd is busy
OK, that's really terrible :-( In some way this is LSP's fault, the whole
design is around async unreliable lang
qchateau created this revision.
qchateau added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar.
qchateau requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.
This allows quick ta
