[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added a comment. In D94735#2500129 , @dblaikie wrote: > Ah, seems I was confused by the patch title - it looks like these values > aren't used for FlagFwdDecl records - forward declarations bail out 3356, not > using the file/line created on 3338

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

dblaikie added a comment. Ah, seems I was confused by the patch title - it looks like these values aren't used for FlagFwdDecl records - forward declarations bail out 3356, not using the file/line created on 3338/3339. Seems like this change might lead to a situation of files but no line number

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3339 // Get overall information about the record type for the debug info. llvm::DIFile *DefUnit = getOrCreateFile(RD->getLocation()); - const unsigned Line = - getLineNumber(RD->getLocat

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3338-3339 // Get overall information about the record type for the debug info. llvm::DIFile *DefUnit = getOrCreateFile(RD->getLocation()); - const unsigned Line = - getLineNumber(RD->getLoca

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay added a comment. diff - [30] .debug_abbrev PROGBITS ec7533c 616a22 00 0 0 1 - [31] .debug_info PROGBITS f28bd5e 50f9770b 00 0 0 1 - [32] .debug_ranges PROGBITS 60223469 285e9b0

[PATCH] D94735: CGDebugInfo: Drop unneeded line number for FlagFwdDecl declarations

MaskRay created this revision. MaskRay added reviewers: debug-info, aprantl, dblaikie. Herald added a subscriber: pengfei. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tested with stage 2 -DCMAKE_BUILD_TYPE=Debug clang, the only