This revision was automatically updated to reflect the committed changes.
Closed by commit rGa0e30914f8c8: [clang][Tooling] Get rid of a hack in
SymbolOccurrences, NFCI (authored by miyuki).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94599/new/
h
simon_tatham accepted this revision.
simon_tatham added a comment.
Thanks. LGTM now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94599/new/
https://reviews.llvm.org/D94599
___
cfe-commits mailing list
miyuki updated this revision to Diff 317627.
miyuki edited the summary of this revision.
miyuki added a comment.
Added `static_assert`s that check that `SourceRange` and `SourceLocation` are
trivially destructible.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
simon_tatham added inline comments.
Comment at:
clang/include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:81
+ union {
+SourceRange SingleRange;
+unsigned NumRanges;
simon_tatham wrote:
> This surely relies on `SourceRange` having no destructor
simon_tatham added inline comments.
Comment at:
clang/include/clang/Tooling/Refactoring/Rename/SymbolOccurrences.h:81
+ union {
+SourceRange SingleRange;
+unsigned NumRanges;
This surely relies on `SourceRange` having no destructor (or rather, a trivial
miyuki added a comment.
I will wait until the end of this week to see if anyone has objections.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94599/new/
https://reviews.llvm.org/D94599
___
cfe-commits ma
miyuki created this revision.
miyuki added reviewers: aprantl, dexonsmith, arphaman.
miyuki requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The class `SymbolOccurrences` can store either a single `SourceRange`
in-place or multiple `SourceRa
