[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-25 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf19849a07b67: [RISCV] Update V extension to v1.0-draft 08a0b464. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-25 Thread Evandro Menezes via Phabricator via cfe-commits
evandro added a comment. Also, when the V spec becomes official, it'll be labeled v2.0. Therefore, as long as v0.9 or v1.0 is implemented, V is only available as an experimental feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ h

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-25 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 318929. HsiangKai added a comment. Herald added subscribers: jdoerfert, hiraditya. Herald added a project: LLVM. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ https://reviews.llvm.org/D9458

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-25 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. Could you also update macros and attributes which implemented in https://reviews.llvm.org/D94403 and https://reviews.llvm.org/D94931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ https://reviews.llvm.org/D945

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D94583#2514434 , @jrtc27 wrote: > In D94583#2513915 , @HsiangKai wrote: > >> In D94583#2513070 , @jrtc27 wrote: >> >>> There are a lot of "Resol

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng added a comment. @jrtc27 just let you know I have same concern too, that's one major reason why we don't upstream those extension on GNU toolchain... we are intend to introduce an internal revision number on ELF attribute in near future, e.g. v-ext 0.9.1 / v0p9p1 to prevent compatibl

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. (Their problem stems from having 1.0 drafts before they've resolved all the outstanding issues and frozen the instruction set; if they didn't jump the gun then things would be saner for people implementing it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. In D94583#2513915 , @HsiangKai wrote: > In D94583#2513070 , @jrtc27 wrote: > >> There are a lot of "Resolve for v1.0" issues open against the spec still. >> Are we sure we want to brand this

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. In D94583#2513070 , @jrtc27 wrote: > There are a lot of "Resolve for v1.0" issues open against the spec still. Are > we sure we want to brand this as 1.0? It will end up as such in the ELF > attributes and thus be deemed compat

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Jessica Clarke via Phabricator via cfe-commits
jrtc27 added a comment. There are a lot of "Resolve for v1.0" issues open against the spec still. Are we sure we want to brand this as 1.0? It will end up as such in the ELF attributes and thus be deemed compatible with future "real" 1.0 binaries. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Craig Topper via Phabricator via cfe-commits
craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94583/new/ https://reviews.llvm.org/D94583 _

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-21 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 318221. HsiangKai added a comment. Use v1.0 instead of strange version number. It is under -enable-experimental-extensions. So, I think it should be ok to do this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D94583: [RISCV] Update V extension to v1.0-draft 08a0b464.

2021-01-12 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai created this revision. HsiangKai added reviewers: craig.topper, evandro, rogfer01, frasercrmck, asb, luismarques, kito-cheng. Herald added subscribers: NickHung, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones