[PATCH] D94289: [clangd] Add go-to-def metric.

2021-01-08 Thread Haojian Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e36d21fabcd: [clangd] Add go-to-def metric. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D94289: [clangd] Add go-to-def metric.

2021-01-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 315480. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94289/new/ https://reviews.llvm.org/D94289 Files: clang-tools-extra/cla

[PATCH] D94289: [clangd] Add go-to-def metric.

2021-01-08 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:375 VirtualMethods.insert(getSymbolID(CMD)); + LocateASTReferentMetric.record(1, "go-to-overrides

[PATCH] D94289: [clangd] Add go-to-def metric.

2021-01-08 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang. to track the number of different "special" go-to-def