[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

This revision was automatically updated to reflect the committed changes. Closed by commit rGee27c767bd20: [clang-format] Skip UTF8 Byte Order Mark while sorting includes (authored by rjelonek, committed by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315516. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. @curdeius Can you commit this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315424. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. I do not have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

MyDeveloperDay added a comment. In D94201#2483824 , @HazardyKnusperkeks wrote: > Should the BOM not be ignored in ANY case, not just while sorting includes? > And thus a different code should be touched? > > How about aligned assignments at the beginning

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

HazardyKnusperkeks added a comment. Should the BOM not be ignored in ANY case, not just while sorting includes? And thus a different code should be touched? How about aligned assignments at the beginning of the line with a BOM, does it count to the type name, or does clang-format handle that co