[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

2021-01-06 Thread Varun Gandhi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG37e83bc6db3a: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy (authored by varungandhi-apple). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

2021-01-06 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94196/new/ https://reviews.llvm.org/D94196 _

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

2021-01-06 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple updated this revision to Diff 315005. varungandhi-apple added a comment. Appease clang-tidy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94196/new/ https://reviews.llvm.org/D94196 Files: clang/include/clang/AST/APValue.h cl

[PATCH] D94196: [NFC] Move readAPValue/writeAPValue up the inheritance hierarchy

2021-01-06 Thread Varun Gandhi via Phabricator via cfe-commits
varungandhi-apple created this revision. varungandhi-apple added a reviewer: rjmccall. varungandhi-apple requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The implementation for (de)serialization of APValues can be shared between Clang and Sw