aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
steveire wrote:
> aaron.ballman wrote:
> > steveire wr
steveire abandoned this revision.
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
aaron.ballman wrote:
> st
aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
steveire wrote:
> aaron.ballman wrote:
> > steveire wr
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
aaron.ballman wrote:
> steveire wrote:
> > aaron.ballman wr
aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
steveire wrote:
> aaron.ballman wrote:
> > Does it mak
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
aaron.ballman wrote:
> Does it make sense to return `true`
aaron.ballman added inline comments.
Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:402
ArrayRef InnerMatchers) {
+ if (InnerMatchers.empty())
+return true;
Does it make sense to return `true` when there are no
steveire created this revision.
steveire added a reviewer: aaron.ballman.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
When debugging a matcher it is convenient to be able to comment out
nested matchers experimentally. This stop
