thakis added a comment.
Looks like this worked :)
Thanks again!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93979/new/
https://reviews.llvm.org/D93979
___
cfe-commits mailing list
cfe-commits@lists.ll
njames93 added a comment.
http://45.33.8.238/win/30678/summary.html It looks like it works, as nothing
needed to be built it was a v fast build
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93979/new/
https://reviews.llvm.org/D93979
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rG59810c51e761: [clang-tidy] Fix windows tests (authored by
njames93).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93979/new/
https://reviews.llvm.org/D9397
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Hey, thanks!
I don't have a win machine at hand either, but let's land this and see what the
win bot on http://45.33.8.238/ thinks about this. It should take at most 15 min
to cycle.
Reposi
njames93 added a comment.
I don't have a (reliable) windows machine to test so can you take a look please
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93979/new/
https://reviews.llvm.org/D93979
___
cfe-
njames93 created this revision.
njames93 added a reviewer: thakis.
Herald added subscribers: kbarton, xazax.hun, nemanjai.
njames93 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Attempt to fix the 2 failing tests identifier in 48646.
Appe
