[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

2021-01-08 Thread Xiangling Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe97071d79520: [NFC] Renaming PackStack to AlignPackStack (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

2021-01-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/D93901 ___

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

2021-01-06 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 314911. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Add pre-committing tests with the incorrect behaviour as part of the NFC patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93901/new/ https://reviews.llvm.org/

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

2021-01-03 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:65-67 + // The #pragma align/pack affected a record in an included file, so Clang + // should warn when that pragma was written in a file that included the + // included file. --

[PATCH] D93901: [NFC] Renaming PackStack to AlignPackStack

2020-12-29 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, efriedma, jyknight, aaron.ballman. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch renames `PackStack` and related var