[PATCH] D93873: [clangd] Cache preambles of closed files

kadircet added a comment. In D93873#2490314 , @sammccall wrote: > 1. a *persistent* cache so closing+reopening clangd loses less state. (This > is complicated because only the PCH is easily serializable, the rest of the > PreambleData struct isn't) > 2.

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau added a comment. Hey, don't worry about the delay, I won't have as much time on my hands anymore anyway. - we can definitely make this opt-in - MB instead of # is an idea, it's probably closer to what the user want to configure - if he does - but it would also probably give a worse def

[PATCH] D93873: [clangd] Cache preambles of closed files

sammccall added a reviewer: kadircet. sammccall added a comment. Thanks! This is a really good idea, but not without its risks :-) Sorry for not getting to this for a while! My only *really* high-level design question is: I wonder what the tradeoffs are in keeping just the preamble vs the whole

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau added a comment. New year's ping ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93873/new/ https://reviews.llvm.org/D93873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau updated this revision to Diff 314152. qchateau added a comment. - Fix keep preamble command line option - Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93873/new/ https://reviews.llvm.org/D93873 Files: clang-tools-extra/clangd

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. When a file is close