[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2021-02-03 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. In D93787#2539111 , @vabridgers wrote: > Abandoning this change request in favor of @steakhal 's more comprehensive > change @ https://reviews.llvm.org/D93222 Let me know if that patch-stack resolves your crash. I don't mind e

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2021-02-03 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers abandoned this revision. vabridgers added a comment. Abandoning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___ cfe-commits mailing list cfe-commi

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2021-02-03 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Abandoning this change request in favor of @steakhal 's more comprehensive change @ https://reviews.llvm.org/D93222 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D93787 ___

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-26 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:1241 if (TheTok.getIdentifierInfo() == VariadicParamII) { -TStream.injectRange(PrevParamMap.at(VariadicParamII)); +if (PrevParamMap.find(VariadicPar

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-26 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers added a comment. Thanks @steakhal , I found your Bugzilla bug only after I submitted this patch. I'll revise based on your comments and resubmit. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93787/new/ https://reviews.llvm.org/D9

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-25 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a reviewer: steakhal. steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. This form of macro expansion is obsolete - I hope that the community agrees on this. Crashes for many more cases then just the one you mention

[PATCH] D93787: [analyzer] Fix crash caused by accessing empty map

2020-12-23 Thread Vince Bridgers via Phabricator via cfe-commits
vabridgers created this revision. vabridgers added a reviewer: Szelethus. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. Herald a