[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-18 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 317292. HazardyKnusperkeks added a comment. Fix documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 Files: clang/docs/ClangFormatStyleOptions.rs

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-17 Thread Björn Schäpers via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcc1dee60019: [clang-format] Add StatementAttributeLikeMacros option (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-17 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks updated this revision to Diff 317268. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Sorting corrected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Please address the "not done" comment (regarding the sorting), but other than that its LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D9

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-16 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM apart from the minor comment. But I'd like @mydeveloperday to have a look too. Comment at: clang/lib/Format/FormatToken.h:54 TYPE(FunctionTypeLParen)

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2021-01-15 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. *ping* And I don't have a better name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 ___ cfe-commits mailing list cfe-commit

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2020-12-23 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. In D93776#2470524 , @curdeius wrote: > Seems okay at the first glance. I'm wondering if we can find a better name > though. I'm all in for a better name. :) I could not think of any (my first shot was `IgnoredMacros`,

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2020-12-23 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Seems okay at the first glance. I'm wondering if we can find a better name though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93776/new/ https://reviews.llvm.org/D93776 ___

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2020-12-23 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:54 TYPE(FunctionTypeLParen) \ + TYPE(StatementAttributeLikeMacro) \ TYPE(ImplicitStringLite

[PATCH] D93776: [clang-format] Add StatementAttributeLikeMacros option

2020-12-23 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, JVApen. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows