[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Joachim Meyer via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc755e41c336c: Fix -Wno-error= parsing in clang-format. (authored by fodinabor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Joachim Meyer via Phabricator via cfe-commits
fodinabor updated this revision to Diff 312596. fodinabor added a comment. Update ClangFormat.rst. This is manually well formatted.. will try to make a new patch in the coming days to actually fix it in the support library. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 _

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Joachim Meyer via Phabricator via cfe-commits
fodinabor updated this revision to Diff 312518. fodinabor added a comment. Add lit test to ensure behaviour of the -Wno-error=unkown flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93459/new/ https://reviews.llvm.org/D93459 Files: clang/test

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D93459#2460445 , @fodinabor wrote: > Btw. is there a way to add tests for command-line options, so this won't > happen unnoticed again? I'd guess some lit tests could be used to verify the command line syntax is correct /

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Joachim Meyer via Phabricator via cfe-commits
fodinabor added a comment. Quoting my questions from the other review, as it should be more appropriate to discuss this here: The formatting of the `--help` page is still slightly off (I guess `cl::values` descriptions are supposed to be single line), so I guess I have to investigate my format

[PATCH] D93459: Fix -Wno-error= parsing in clang-format.

2020-12-17 Thread Joachim Meyer via Phabricator via cfe-commits
fodinabor created this revision. fodinabor added reviewers: MyDeveloperDay, JakeMerdichAMD. fodinabor requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted in https://reviews.llvm.org/D86137#2460135 parsing of the clang-format parameter