[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Jon Chesterfield via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0619d3b21cd: [NFC] Use regex for code object version in hip tests (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Tony Tye via Phabricator via cfe-commits
t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93398/new/ https://reviews.llvm.org/D93398 ___ cfe

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +//

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +// VD: "-tar

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Tony Tye via Phabricator via cfe-commits
t-tye added inline comments. Comment at: clang/test/Driver/hip-code-object-version.hip:56 -// V4: "-mllvm" "--amdhsa-code-object-version=4" -// V4: "-targets=host-x86_64-unknown-linux,hip-amdgcn-amd-amdhsa--gfx906" +// VD: "-mllvm" "--amdhsa-code-object-version=4" +// VD: "-tar

[PATCH] D93398: [NFC] Use regex for code object version in hip tests

2020-12-16 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield created this revision. JonChesterfield added a reviewer: yaxunl. JonChesterfield requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] Use regex for code object version in hip tests Extracted from D93258