[PATCH] D93325: Add srcloc output to clang-query

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d018c79ee5f: Add srcloc output to clang-query (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D93325?vs=339583&id=3

[PATCH] D93325: Add srcloc output to clang-query

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the nits from @njames93 and I. Comment at: clang-tools-extra/clang-query/Query.cpp:96 + + auto printLocations = [](auto &OS, auto Iter, auto En

[PATCH] D93325: Add srcloc output to clang-query

njames93 added inline comments. Comment at: clang-tools-extra/clang-query/Query.cpp:106-108 + if (Scout->first == CommonEntry) { +++Iter; + } nit: Elide braces. Comment at: clang-tools-extra/clang-query/Query.cpp:122 + +Te

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 339583. steveire added a comment. Herald added a subscriber: mgrang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-query/CMak

[PATCH] D93325: Add srcloc output to clang-query

steveire added a comment. @aaron.ballman ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336690. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-query/CMakeLists.txt clang-tools-extra/clan

[PATCH] D93325: Add srcloc output to clang-query

steveire updated this revision to Diff 336652. steveire added a comment. Herald added a subscriber: mgorny. Herald added a project: clang-tools-extra. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93325/new/ https://reviews.llvm.org/D93325

[PATCH] D93325: Add srcloc output to clang-query

aaron.ballman added a comment. Thank you for this, it looks really useful! Comment at: clang-tools-extra/clang-query/Query.cpp:94 +void dumpLocations(llvm::raw_ostream &OS, ast_type_traits::DynTypedNode node, + ASTContext &Ctx, const DiagnosticsEngine &Diags

[PATCH] D93325: Add srcloc output to clang-query

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93325 Files: clang-tools-extra/clang-quer