[PATCH] D93258: [amdgpu] Default to code object v3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaf39e3f2dba: [amdgpu] Default to code object v3 (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 312236. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/clang/Driver/Options.td clang/lib/Dri

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2457905 , @yaxunl wrote: > Thanks for fixing the lit tests. Using regex is the right choice. > > Do we have a plan about how to merge this to amd-stg-open? Will it cause > ePSDB to fail? Do you have a follow up p

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl added a comment. Thanks for fixing the lit tests. Using regex is the right choice. Do we have a plan about how to merge this to amd-stg-open? Will it cause ePSDB to fail? Do you have a follow up patch to make amd-stg-open happy? Thanks. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. @yaxunl Please see Gerrit 456139 for a close approximation to the test changes here. I don't think hip should be hard coding a version number in tests that don't care about it, so would like to move trunk and internal to a regex. Repository: rG LLVM Github Mo

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 312196. JonChesterfield added a comment. - Remove hard coded version numbers in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/cla

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2453828 , @yaxunl wrote: > Can they use rocm release branches of llvm/clang with the corresponding rocm > release? As llvm/clang trunk is like the development branch, it is > understandable that they may contain

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl added a comment. In D93258#2453815 , @JonChesterfield wrote: > In D93258#2453724 , @thakis wrote: > >> reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca >>

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield added a comment. In D93258#2453724 , @thakis wrote: > reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca > for now Thanks! Just saw the CI emails come through. I didn

[PATCH] D93258: [amdgpu] Default to code object v3

yaxunl reopened this revision. yaxunl added a comment. This revision is now accepted and ready to land. @JonChesterfield Did this patch pass ePSDB in gerrlit? Better do that before committing it to trunk since we don't know if math libs are compatible with this patch. Also you need to fix lit te

[PATCH] D93258: [amdgpu] Default to code object v3

thakis added a comment. reverted in c9ede6f3367a627baeef78f30d18078af9a4ffca for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 __

[PATCH] D93258: [amdgpu] Default to code object v3

thakis added a comment. This seems to break check-clang everywhere: http://45.33.8.238/linux/35295/step_7.txt PTAL, and if it takes a while to investigate, please revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://re

[PATCH] D93258: [amdgpu] Default to code object v3

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b2e7d021502: [amdgpu] Default to code object v3 (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D93258: [amdgpu] Default to code object v3

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 ___ cfe

[PATCH] D93258: [amdgpu] Default to code object v3

t-tye added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:2874-2876 .. warning:: Code object V3 is not the default code object version emitted by this version of LLVM. Move this to the "Code Object V4 Metadata" section. Repository: rG LLVM Git

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 311746. JonChesterfield added a comment. - another part of docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93258/new/ https://reviews.llvm.org/D93258 Files: clang/include/clang/Driver/Options.td

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield updated this revision to Diff 311745. JonChesterfield added a comment. Herald added subscribers: llvm-commits, dang, kerbowa, nhaehnle, jvesely. Herald added a project: LLVM. - update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D93258: [amdgpu] Default to code object v3

JonChesterfield created this revision. JonChesterfield added a reviewer: t-tye. Herald added subscribers: tpr, dstuttard, yaxunl, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. [amdgpu] Default to code object