[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks added a comment. In D93240#4254439 , @sstwcw wrote: > A goto label isn't affected by this option. Is it intentional? Of course, because it's only for `case`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. In D93240#4254439 , @sstwcw wrote: > A goto label isn't affected by this option. Is it intentional? why would it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ h

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

sstwcw added a comment. Herald added a project: All. Herald added reviewers: rymiel, owenpan. A goto label isn't affected by this option. Is it intentional? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ https://reviews.llvm.org/D93240

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

This revision was automatically updated to reflect the committed changes. Closed by commit rG47877c9079c2: [clang-format] Add SpaceBeforeCaseColon option (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ http

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks updated this revision to Diff 312877. HazardyKnusperkeks added a comment. Test case adapted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93240/new/ https://reviews.llvm.org/D93240 Files: clang/docs/ClangFormatStyleOptions.rs

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. Nit: Please just separate your test from old test Comment at: clang/unittests/Format/FormatTest.cpp:12158 "default:\n" + " break;\n" "}", HazardyKnusperkeks wrote: > MyDeveloperDay w

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. In D93240#2454268 , @MyDeveloperDay wrote: > I generally don't have the same aversion to new options than others have, but > can you point out a style guide that mig

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:12115 + " break;\n" "}", InheritanceStyle); maybe add a `default` example with {} try not to change existing tests just add you

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

MyDeveloperDay added a comment. I generally don't have the same aversion to new options than others have, but can you point out a style guide that might want this option. (that is kind of the process) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D93240: [clang-format] Add SpaceBeforeCaseColon option

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, klimek, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If ``false``