[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

void added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/LogFunctionsCheck.cpp:51 +void LogFunctionsCheck::check(const MatchFinder::MatchResult &Result) { + if (FixerKind == LFFK_H) { +const auto *Call = Result.Nodes.getNodeAs("call"); ---

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

void added a comment. In D93182#2451509 , @lebedev.ri wrote: > Out of curiocity, are all checkpatch diagnostics (and something else)? > are planned to be ported into being clang-tidy checks? > How many will checks will that be? > I'll be slightly worried i

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

nickdesaulniers added a comment. In D93182#2451509 , @lebedev.ri wrote: > Out of curiocity, are all checkpatch diagnostics (and something else)? > are planned to be ported into being clang-tidy checks? Not at this time, no. > How many will checks will th

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

trixirt added a comment. Yes, this change has problems, I will resubmit. There are many log function checks in checkpatch, and i need to write another one to find the unattibuted decls. I don't think adding linux specific warnings is -Wformat is needed, that doesn't scale with all the other pro

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

lebedev.ri added a comment. Out of curiocity, are all checkpatch diagnostics (and something else)? are planned to be ported into being clang-tidy checks? How many will checks will that be? I'll be slightly worried if `linuxkernel` module ends up having more checks than all other modules combined..

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

Eugene.Zelenko added a comment. Maybe Clang's `-Wformat` should be extended to cover Linux kernel-specific format options? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93182/new/ https://reviews.llvm.org/D93182 __

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

njames93 added a comment. This check needs documentation adding in `clang-tools-extra/docs/clang-tidy/checks/linux-kernel-logfunctions-h.rst` Also needs to add this in `clang-tools-extra/docs/clang-tidy/checks/list.rst`, keeping it in alphabetical order. Also need to add an entry to `clang-tools

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

trixirt created this revision. trixirt added reviewers: nickdesaulniers, alexfh, hokein, aaron.ballman, njames93. trixirt added a project: clang-tools-extra. Herald added subscribers: Charusso, xazax.hun, mgorny. trixirt requested review of this revision. Herald added a project: clang. Herald adde