This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4ddf140c0040: Fix PR35902: incorrect alignment used for
ubsan check. (authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D93
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/CodeGen/CGCXXABI.cpp:138
if (MD->getParent()->getNumVBases() == 0 || // avoid vcall in common case
MD->getParent()->hasAttr() ||
+ is
jyknight created this revision.
jyknight added reviewers: rsmith, rnk.
jyknight requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
UBSan was using the complete-object align rather than nv alignment
when checking the "this" pointer of a method.