This revision was automatically updated to reflect the committed changes.
Closed by commit rG90bf3ecef4bb: [clang-offload-bundler] Add option -list
(authored by yaxunl).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D929
yaxunl updated this revision to Diff 314957.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
revised by Artem's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm.org/D92954
Files:
clang/test/Driver/clang-offload-bundler.c
clang/
yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176
+ /// List bundle IDs in \a Input.
+ virtual Error listBundleIDs(MemoryBuffer &Input) {
+if (Error Err = ReadHeader(Input))
-
tra added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:176
+ /// List bundle IDs in \a Input.
+ virtual Error listBundleIDs(MemoryBuffer &Input) {
+if (Error Err = ReadHeader(Input))
Now that listBundleIDs is only u
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm.org/D92954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm.org/D92954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 311187.
yaxunl marked 3 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm.org/D92954
Files:
clang/test/Driver/clang-offload-bundler.c
clang
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:188
+
+ if (Error Err = Func())
+return Err;
tra wrote:
> Now, if we could save the triple in a `BundleInfo`
tra added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:188
+
+ if (Error Err = Func())
+return Err;
Now, if we could save the triple in a `BundleInfo` when it's parsed, and pass
`BundleInfo` to `Func()` that
yaxunl updated this revision to Diff 310751.
yaxunl added a comment.
Remove unnecessary formatting changes.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm.org/D92954
Files:
clang/test/Driver/clang-offload-bundler.c
clang/tools/clang-offload-bundler/Cl
yaxunl added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:763
+
+// Create an intermediate temporary file for reading the bundles.
+TempFileHandlerRAII TempFiles;
tra wrote:
> Having to create a temporary file in
yaxunl updated this revision to Diff 310748.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by Artem's comments: removing unnecessary output to temporary file,
extract forEachBundle.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92954/new/
https://reviews.llvm
tra added inline comments.
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:763
+
+// Create an intermediate temporary file for reading the bundles.
+TempFileHandlerRAII TempFiles;
Having to create a temporary file in order to *list*
yaxunl created this revision.
yaxunl added a reviewer: tra.
yaxunl requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
clang-offload-bundler is not only used by clang driver
to bundle/unbundle files for offloading toolchains,
but also used by
14 matches
Mail list logo
