[PATCH] D92774: [clang][cli] Add command line marshalling tests

2020-12-08 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. I'm sorry about that, I understand that was hard to review. This is now split this into multiple patches: D92825 , D92826 , D92827 , D92828

[PATCH] D92774: [clang][cli] Add command line marshalling tests

2020-12-08 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 updated this revision to Diff 310134. jansvoboda11 added a comment. Split into multiple patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvoca

[PATCH] D92774: [clang][cli] Add command line marshalling tests

2020-12-07 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I think the content here is mostly good, but there a number of things intermingled so it's hard see what's going on. I suggest splitting out one or more NFC commits to land a

[PATCH] D92774: [clang][cli] Add command line marshalling tests

2020-12-07 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more tests of the command line marshalling infrastructure. The new tests now make a "