This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG445289aa63e1: [clangd] Fix an assertion violation in rename.
(authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
hokein updated this revision to Diff 309506.
hokein marked an inline comment as done.
hokein added a comment.
address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92642/new/
https://reviews.llvm.org/D92642
Files:
clang-tools-extra/clan
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:949
+ {R"cpp(// disallow rename on non-normal identifiers.
+ @interface Foo {}
---
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang.
NamedDecl::getName() asserts the name must be an ide
