[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314052. Bdragon28 added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Add missing OpenMP TLS test for powerpcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a reviewer: q66. Bdragon28 added a comment. Add q66 to reviewers list for the targeting bits relevant to Void ppcle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 _

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313931. Bdragon28 added a comment. - Fix LLVM object handling unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313930. Bdragon28 added a comment. Herald added a subscriber: mgorny. - Fix bug in clang/test/Driver/linux-header-search.cpp -- The powerpc64le test was being done with -m32 accidentally. - Update llvm/unittests/ADT/TripleTest.cpp for powerpcle. - Update gc

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314019. Bdragon28 added a comment. Re-uploading patch for part 5 now that I have the dependency tree fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: l

[PATCH] D92445: [PowerPC] Add powerpcle target. (5/5)

Bdragon28 updated this revision to Diff 314012. Bdragon28 retitled this revision from "[PowerPC] Add powerpcle target." to "[PowerPC] Add powerpcle target. (5/5)". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313655. Bdragon28 added a comment. Fix merge base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTa

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 marked 2 inline comments as done. Bdragon28 added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2152 + "powerpcle-unknown-linux-gnu", + "powerpcle-unknown-freebsd"

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313654. Bdragon28 added a comment. - Address review comment from MaskRay. - Incorporate changes from the Void powerpcle patchset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llv

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313651. Bdragon28 added a comment. Trying again.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTar

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added a comment. The lld/ELF part change looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313649. Bdragon28 edited the summary of this revision. Bdragon28 added a comment. Splitting up into multiple commits as per MaskRay's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:358 resetDataLayout("E-m:a-p:32:32-i64:64-n32"); +else if ((Triple.getArch() == llvm::Triple::ppcle)) + resetDataLayout("e-m:e-p:32:32-i64:64-n32"); redundant `()`

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. I've tested the patch (applied to LLVM11) and can confirm it works. There have been some changes/fixes I needed to do, which I already reported on IRC, so I will not include them here (Bdragon28 should just be able to apply them and push them out) Right now, I have a full

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. we are also interested in running this on "true" 32-bit hardware eventually, so not restricting to POWER7 would be a good thing, potentially Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92

[PATCH] D92445: [PowerPC] Add powerpcle target.

q66 added a comment. I am interested in this, since we are currently bootstrapping an entire ppcle userland in our distribution (glibc and musl) - we already have everything generally working (on ppc64le host), with llvm being a notable blocker for some things - so i will be testing this in nea

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2428563 , @sfertile wrote: >> On FreeBSD, the main use of this will be on the new powerpc64le arch, where >> we need to build a 32-bit LE bootloader for use with pseries. (it is easier >> to retarget LLVM than make a

[PATCH] D92445: [PowerPC] Add powerpcle target.

tstellar added a comment. Could you add some more information to the commit message to better describe the powerpcle target. It's not clear from the target name exactly what it is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ htt

[PATCH] D92445: [PowerPC] Add powerpcle target.

sfertile added a comment. > On FreeBSD, the main use of this will be on the new powerpc64le arch, where > we need to build a 32-bit LE bootloader for use with pseries. (it is easier > to retarget LLVM than make a cross-endian bootloader, as it would involve > rewriting filesystem code etc.) Ex

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. Regarding things like Altivec and VSX: Altivec should be just fine to run in 32-bit LE. I am undecided as to whether VSX should be banned or not. However that goes, it should be identical in powerpc64 -m32 and powerpc64le -m32. Regarding codegen: CPU capabilities are a

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427537 , @Bdragon28 wrote: > In D92445#2427438 , @nemanjai wrote: > >> This seems problematic to me for a few reasons: >> >> 1. There is no 32-bit toolchains or libraries for li

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427439 , @MaskRay wrote: > This patch should be split. I suggest that you create 4 patches. > > - llvm: triple change > - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump > - clang > - lld Can do. Reposit

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. In D92445#2427438 , @nemanjai wrote: > This seems problematic to me for a few reasons: > > 1. There is no 32-bit toolchains or libraries for little endian Linux systems > 2. There is no support in the ELFv2 ABI for 32-bit object

[PATCH] D92445: [PowerPC] Add powerpcle target.

MaskRay added a comment. This patch should be split. I suggest that you create 4 patches. - llvm: triple change - llvm: llvm/Object/ELFObjectFile.h llvm-readobj llvm-objdump - clang - lld Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ ht

[PATCH] D92445: [PowerPC] Add powerpcle target.

nemanjai added a comment. This seems problematic to me for a few reasons: 1. There is no 32-bit toolchains or libraries for little endian Linux systems 2. There is no support in the ELFv2 ABI for 32-bit object mode and there may be a number of places we assume that little endian systems use ELFv

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 added a comment. On FreeBSD, the main use of this will be on the new powerpc64le arch, where we need to build a 32-bit LE bootloader for use with pseries. (it is easier to retarget LLVM than make a cross-endian bootloader, as it would involve rewriting filesystem code etc.) On Linux,

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 created this revision. Bdragon28 added reviewers: MaskRay, PowerPC, jhibbits. Bdragon28 added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven.zhang, shchenz, rupprecht, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald add