[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

This revision was automatically updated to reflect the committed changes. Closed by commit rGacbb3652931a: [AST][NFC] Silence GCC warning about multiline comments (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https:/

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 __

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2481300 , @rjmccall wrote: > People can't actually just copy/paste from the comment anyway because of the > comment characters on the line, and I don't think anyone will misunderstand > the example if the backslash is mi

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre updated this revision to Diff 315080. thopre added a comment. Change approach to remove continuation line instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 Files: clang/include/clang/AST/Decl

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rjmccall added a comment. People can't actually just copy/paste from the comment anyway because of the comment characters on the line, and I don't think anyone will misunderstand the example if the backslash is missing. It's silly that GCC has a problem with this, but since it does, let's just

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450897 , @thopre wrote: > In D92409#2450690 , @rsmith wrote: > >> In D92409#2450550 , @thopre wrote: >> >>> In D92409#2426196

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2450690 , @rsmith wrote: > In D92409#2450550 , @thopre wrote: > >> In D92409#2426196 , @thopre wrote: >> >>> Is there a way to disable it fr

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rsmith added a comment. In D92409#2450550 , @thopre wrote: > In D92409#2426196 , @thopre wrote: > >> Is there a way to disable it from the header? I've noticed this warning when >> compiling an application using li

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426196 , @thopre wrote: > In D92409#2426188 , @rsmith wrote: > >> Let's just disable this broken GCC warning. IIRC, the corresponding clang >> warning covers the actual bugs cause

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426188 , @rsmith wrote: > Let's just disable this broken GCC warning. IIRC, the corresponding clang > warning covers the actual bugs caused by line continuation in comments, and > doesn't warn if the next line begins wi

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

rsmith added a comment. Let's just disable this broken GCC warning. IIRC, the corresponding clang warning covers the actual bugs caused by line continuation in comments, and doesn't warn if the next line begins with a `//`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre added a comment. In D92409#2426160 , @ABataev wrote: > I would just remove this extra symbol. But then the example code is no longer copy/pastable. Note that I expect people to copy/paste but it's nice if it looks authentic. Note that I don't mind

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

ABataev added a comment. I would just remove this extra symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92409/new/ https://reviews.llvm.org/D92409 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

thopre created this revision. thopre added reviewers: ABataev, rjmccall, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. thopre requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. GCC's -Wcomment warning is emit