[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

thakis added a comment. Reverted in de4f5519015cc97f28718d90cc6dac73c0a15161 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 _

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

thakis added a comment. Looks like this breaks tests on Windows: http://45.33.8.238/win/29513/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 ___ cfe-c

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG634a377bd8cb: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC (authored by sammccall)

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:79 + // Absolute canonical path that we're the cache for. (Not case-folded). + std::string Path; + kadircet wrote: >

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:79 + // Absolute canonical path that we're the cache for. (Not case-folded). + std::str

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. kadircet wrote

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall updated this revision to Diff 309474. sammccall marked 6 inline comments as done. sammccall added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92381/new/ https://reviews.llvm.org/D92381 Files: clang-

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:91 + // Whether a new CDB has been loaded but not broadcast yet. + bool Dirty = false; + // Last loaded CDB, meaningful if CachePopulated is set. maybe rename th

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:89 + // Has cache been filled from disk? FIXME: this should be an expiry time. + bool CachePopulated = false; + // Whether a new CDB has been loaded but not broadcast yet. -

[PATCH] D92381: [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman. Herald added a project: clang. sammccall requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a step towards making compil