[PATCH] D92354: [clang] add a new `swift_attr` attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG03dcd57ecf99: [clang] add a new `swift_attr` attribute (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 __

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman added a comment. Thanks for taking a look. In D92354#2428604 , @erik.pilkington wrote: > Do we need to add APINotes support for this? Not at the moment, maybe in the future Comment at: clang/include/clang/Basic/Attr.td:2153

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman updated this revision to Diff 309553. arphaman marked 2 inline comments as done. arphaman added a comment. Updated for review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92354/new/ https://reviews.llvm.org/D92354 Files: clang

[PATCH] D92354: [clang] add a new `swift_attr` attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2153 +def SwiftAttr : InheritableAttr { + let Spellings = [Clang<"swift_attr">]; + let Args = [StringArgument<"Attribute">]; The other swift attributes use a GNU spelling and don

[PATCH] D92354: [clang] add a new `swift_attr` attribute

erik.pilkington added a comment. Do we need to add APINotes support for this? Comment at: clang/include/clang/Basic/Attr.td:2155 + let Args = [StringArgument<"Attribute">]; + let Documentation = [SwiftAttrDocs]; +} Should we limit this to appear on certain su

[PATCH] D92354: [clang] add a new `swift_attr` attribute

arphaman created this revision. arphaman added reviewers: erik.pilkington, aaron.ballman. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. arphaman requested review of this revision. The `swift_attr` attribute is a generic annotation attribute that's not used by clang,