[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-10 Thread Anastasia Stulova via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa84599f177a6: [OpenCL] Implement extended subgroups fully in headers. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik accepted this revision. PiotrFusik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list cfe-com

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 310227. Anastasia added a comment. - Set all macros to value 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c-base.h

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-08 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_subgroup_ballot +#define cl_khr_subgroup_non_uniform_arithmetic +#define cl_khr_subgroup_shuffle

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-04 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik requested changes to this revision. PiotrFusik added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Headers/opencl-c-base.h:17-23 +#define cl_khr_subgroup_extended_types +#define cl_khr_subgroup_non_uniform_vote +#define cl_khr_su

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-03 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D92231#2425323 , @Anastasia wrote: > In D92231#2425305 , @PiotrFusik > wrote: > >> The specification for these extensions was edited by Ben Ashbaugh @Intel. >> I've asked him about th

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-01 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In D92231#2425305 , @PiotrFusik wrote: > The specification for these extensions was edited by Ben Ashbaugh @Intel. > I've asked him about this change. Sure. Thanks! Happy to hold off committing for a few days to see if Ben has

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-01 Thread Piotr Fusik via Phabricator via cfe-commits
PiotrFusik added a comment. These specification for these extensions was edited by Ben Ashbaugh @Intel. I've asked him about this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commit

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-12-01 Thread Sven van Haastregt via Phabricator via cfe-commits
svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92231/new/ https://reviews.llvm.org/D92231 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

2020-11-27 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia created this revision. Anastasia added reviewers: azabaznov, AlexeySotkin, mantognini, svenvh, PiotrFusik. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Extended subgroups extensions were added in https://reviews.llvm.org/D79781, however, in th