[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev added a comment. Yes, the idea here is to provide logging for gRPC server state. My original thought was that default `HealthCheck` might not be enough and we might want to add more things in the mechanism but I guess it's not obvious what these extensions might be and getting `grpc_co

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 308269. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Herald added a subscriber: jfb. Use WaitForStateChange instead. Simplify code structure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D92198: [clangd] Implement remote index handshake

sammccall added a comment. It'd be nice to know what problem this is trying to solve :-) I can guess, but don't feel entirely sure here. In D92198#2420203 , @kadircet wrote: > Haven't checked the details but is there a specific reason for implementing a

[PATCH] D92198: [clangd] Implement remote index handshake

kadircet added a comment. Haven't checked the details but is there a specific reason for implementing a custom protocol rather than making use of `NotifyOnStateChange` (https://grpc.github.io/grpc/cpp/classgrpc_1_1_channel_interface.html) or even `WaitForStateChange` if we really want to block

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307943. kbobyrev added a comment. Remove unused header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/remote/Client.cpp cla

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307942. kbobyrev added a comment. This is working now. However, the handshake is actually deferred for ProjectAwareIndex until the first request. I tried to invoke it via something like `Opts.StaticIdx->estimateMemoryUsage()` in `ClangdMain.cpp` but the probl

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev updated this revision to Diff 307936. kbobyrev added a comment. Remove some logs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools-extra/clangd/index/Index.h clang-tools-extra

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev planned changes to this revision. kbobyrev added a comment. This is not working properly yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-com

[PATCH] D92198: [clangd] Implement remote index handshake

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. WIP. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/